[Tarantool-patches] [PATCH v6 00/25] Add static analysis with luacheck
Alexander Turenko
alexander.turenko at tarantool.org
Mon Jun 1 20:29:04 MSK 2020
On Mon, Jun 01, 2020 at 07:08:09PM +0200, Vladislav Shpilevoy wrote:
> Hi!
>
> Sorry, looks like this version also is not the final. Alexander T.
> joined the review, and Igor still has comments. So I am going to
> skip this one, and review the next version.
I just noted my objections against enabling redefinition warning by
default. I asked this two times in March, but it was in a chat and it
seems it was missed.
Also noted objection against removing unused arguments, when they show a
function contract.
Nothing more. It is not full review and I hope I will not asked to do
it.
WBR, Alexander Turenko.
More information about the Tarantool-patches
mailing list