[Tarantool-patches] [PATCH 02/16] Check data_offset overflow in struct tuple

[Vladislav Shpilevoy]

>> So this test would crash even without multikeys? With just too many
>> field offsets? How long does it work?
> Yes, the bug was introduced long time before multikeys.
> The test runs 1.3 second on my comp, and my comp is quite good.
>>
>> And why do you need to try to many combinations, if you know which one was
>> going to crash before the patch?
> 
> I want the test to be more universal. For example in further commits I grab
> one bit from data_offset for is_dirty flag, and the test still checks the possible
> crash while max allowed data_offset have changed.

But wouldn't it still be the same universal, if you would just take the biggest
possible meta size? If we will someday loose the check, it will catch the
problem anyway. With a long test I am afraid its fail won't be noticed, since
long tests are not run locally by anybody. In CI they are run by coverage only.

Anyway, I am ok with the patch.