[Tarantool-patches] [PATCH 02/16] Check data_offset overflow in struct tuple

Aleksandr Lyapunov alyapunov at tarantool.org
Tue Jul 14 20:09:16 MSK 2020


Hi! thanks for review! see my replys below.

On 12.07.2020 20:15, Vladislav Shpilevoy wrote:
>
> So this test would crash even without multikeys? With just too many
> field offsets? How long does it work?
Yes, the bug was introduced long time before multikeys.
The test runs 1.3 second on my comp, and my comp is quite good.
>
> And why do you need to try to many combinations, if you know which one was
> going to crash before the patch?

I want the test to be more universal. For example in further commits I grab
one bit from data_offset for is_dirty flag, and the test still checks 
the possible
crash while max allowed data_offset have changed.



More information about the Tarantool-patches mailing list