[Tarantool-patches] [PATCH 1/2] alter: use good c++ style
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Mon Jul 13 21:33:20 MSK 2020
On 13.07.2020 15:36, Aleksandr Lyapunov wrote:
> Hi! Thanks for the review! all good except one more question below?
>
> On 11.07.2020 22:53, Vladislav Shpilevoy wrote:
>>
>>> void
>>> -UpdateSchemaVersion::alter(struct alter_space *alter)
>>> +UpdateSchemaVersion::alter(struct alter_space *alter) noexcept
>>> {
>>> - (void)alter;
>>> - ++schema_version;
>>> + (void) alter;
>>> + ++schema_version;
>> 3. This change seems not to be related.
> What are you suggesting to do with it? create separate commit? or don't touch it? I hope I haven't to have an gh issue for that.
I would just drop it. It is not needed. Not visually nor
functionally nothing changes. But whatever. Keep if you want.
More information about the Tarantool-patches
mailing list