[Tarantool-patches] [PATCH 1/2] alter: use good c++ style
Aleksandr Lyapunov
alyapunov at tarantool.org
Mon Jul 13 16:36:56 MSK 2020
Hi! Thanks for the review! all good except one more question below?
On 11.07.2020 22:53, Vladislav Shpilevoy wrote:
>
>> void
>> -UpdateSchemaVersion::alter(struct alter_space *alter)
>> +UpdateSchemaVersion::alter(struct alter_space *alter) noexcept
>> {
>> - (void)alter;
>> - ++schema_version;
>> + (void) alter;
>> + ++schema_version;
> 3. This change seems not to be related.
What are you suggesting to do with it? create separate commit? or don't
touch it? I hope I haven't to have an gh issue for that.
More information about the Tarantool-patches
mailing list