[Tarantool-patches] [PATCH 1/1] recovery: handle local sync txns during recovery

[Kirill Yukhin]

Hello,

On 11 июл 19:05, Vladislav Shpilevoy wrote:
> Recovery uses txn_commit_async() so as not to block the recovery
> process when a synchronous transaction is met. They are either
> committed later when CONFIRM is read, or stay in the limbo after
> recovery.
> 
> However txn_commit_async() assumed it is used for remote
> transactions only, and had some assertions about that. One of them
> crashed in case master restarted and had any synchronous
> transaction in WAL.
> 
> The patch makes txn_commit_async() not assume anything about
> transaction's origin.
> 
> Closes #5163
> ---
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5163-qsync-restart-crash
> Issue: https://github.com/tarantool/tarantool/issues/5163

LGTM.
I've checked your patch into master.

--
Regards, Kirill Yukhin