[Tarantool-patches] [PATCH 1/1] recovery: handle local sync txns during recovery

[Cyrill Gorcunov]

On Sat, Jul 11, 2020 at 07:05:19PM +0200, Vladislav Shpilevoy wrote:
> Recovery uses txn_commit_async() so as not to block the recovery
> process when a synchronous transaction is met. They are either
> committed later when CONFIRM is read, or stay in the limbo after
> recovery.
> 
> However txn_commit_async() assumed it is used for remote
> transactions only, and had some assertions about that. One of them
> crashed in case master restarted and had any synchronous
> transaction in WAL.
> 
> The patch makes txn_commit_async() not assume anything about
> transaction's origin.
> 
> Closes #5163

I might be missing something due to lack of strong understanding
of our current qsync implementation. Still the patch looks reasonable
and simple enough. Thus

Reviewed-by: Cyrill Gorcunov <gorcunov at gmail.com>