[Tarantool-patches] [PATCH v3 4/8] sql: replace ApplyType by CheckType for IN operator

[Mergen Imeev]

On 07.07.2020 01:06, Nikita Pettik wrote:
> On 05 Jul 17:28, Mergen Imeev wrote:
>> On Mon, Jun 29, 2020 at 12:56:30PM +0000, Nikita Pettik wrote:
>>> On 25 Jun 18:17, imeevma at tarantool.org wrote:
>>>> index f7681640e..a2147b0e8 100755
>>>> --- a/test/sql-tap/in3.test.lua
>>>> +++ b/test/sql-tap/in3.test.lua
>>>> @@ -1,6 +1,6 @@
>>>>   #!/usr/bin/env tarantool
>>>>   test = require("sqltester")
>>>> -test:plan(29)
>>>> +test:plan(28)
>>>>   
>>>>   --!./tcltestrunner.lua
>>>>   -- 2007 November 29
>>>> @@ -322,18 +322,6 @@ test:do_test(
>>>>           -- </in3-3.2>
>>>>       })
>>>>   
>>>> -test:do_test(
>>>> -    "in3-3.3",
>>>> -    function()
>>>> -        -- Logically, numeric affinity is applied to both sides before
>>>> -        -- the comparison, but index can't be used.
>>>> -        return exec_neph(" SELECT x IN (SELECT b FROM t1) FROM t2 ")
>>>> -    end, {
>>>> -        -- <in3-3.3>
>>>> -        1, true
>>>> -        -- </in3-3.3>
>>>> -    })
>>>> -
>>> I'd rather not drop this test. It's about scalar-numeric types
>>> interaction. Mb it is not the most suitable place for such test,
>>> but make sure this scenario is covered somewhere else.
>>>
>> I added a few tests with SCALARS in 'sql: remove implicit
>> cast for comparison' commit. However, there is a lot
>> problems with SCALARS at the moment.
> Давай с этим что-то делать. Проблемы где-то описаны? Если нет,
> давай подробно разберем и заведем тикет(ы). Иначе это звучит как
> "idgs потом кто-нибудь это разгребет". В тикете 4230 есть
> пункт про скаляр, но мы почему-то обходим его, оставляя
> проблему as is.
Создал тикет: https://github.com/tarantool/tarantool/issues/5148

В последнем письме ("Re: Check implicit cast between strings and
numbers") Гулузан тоже согласен с тем, что по скалярам мы не
договорились.

>   
>>> The rest is OK as obvious.
>>>