[Tarantool-patches] [PATCH 3/3] box/txn: clear fiber storage right before journal_write

Kirill Yukhin kyukhin at tarantool.org
Thu Feb 27 23:27:16 MSK 2020


On 27 фев 23:20, Cyrill Gorcunov wrote:
> On Thu, Feb 27, 2020 at 10:47:29PM +0300, Kirill Yukhin wrote:
> > Hello,
> > 
> > // This is not an official review. Just a nitpicking.
> > 
> > > +space:insert{1}
> > > +---
> > > +- error: Failed to allocate 0 bytes in region for journal_entry
> > 
> > Why 0? How could we ever fail to allocate 0 bytes?
> 
> To make this message immutable even if size of the journal_entry
> structure get changed. We don't care about the size here but rather
> the fact that allocation failed. If you prefer I can put some
> randomn number here instead.

Now I get it. Sure, let's make it 0 (zero).

--
Regards, Kirill Yukhin



More information about the Tarantool-patches mailing list