[Tarantool-patches] [PATCH 3/3] box/txn: clear fiber storage right before journal_write

Cyrill Gorcunov gorcunov at gmail.com
Thu Feb 27 23:20:31 MSK 2020


On Thu, Feb 27, 2020 at 10:47:29PM +0300, Kirill Yukhin wrote:
> Hello,
> 
> // This is not an official review. Just a nitpicking.
> 
> > +space:insert{1}
> > +---
> > +- error: Failed to allocate 0 bytes in region for journal_entry
> 
> Why 0? How could we ever fail to allocate 0 bytes?

To make this message immutable even if size of the journal_entry
structure get changed. We don't care about the size here but rather
the fact that allocation failed. If you prefer I can put some
randomn number here instead.


More information about the Tarantool-patches mailing list