[Tarantool-patches] [PATCH v3 1/2] b-tree: return NULL on matras_alloc fail

[Konstantin Osipov]

* Nikita Pettik <korablev at tarantool.org> [20/02/04 20:21]:
> > > On 20 Jan 21:13, Ilya Kosarev wrote:
> > > > In bps_tree_create_leaf we use matras_alloc in case
> > > > bps_tree_garbage_pop didn't work out. However it also might not
> > > > succeed. Then we need to return NULL instead of dereferencing NULL
> > > > pointer.
> > 
> > I don't understand the attempt to fix it.
> > 
> > The reason the allocations are not checked - most likely -because
> > BPS should refuse to even begin an operation if there is not
> > enough memory in matras.
> 
> According to the code it doesn't look so. Matras allocation checked
> on fails, except two ones in bps_tree_create_inner() and
> bps_tree_create_leaf().

Because reserve_blocks() should reserve enough blocks or fail, and
it is called before create_inner/create_leaf in all execution paths?

-- 
Konstantin Osipov, Moscow, Russia