[Tarantool-patches] [PATCH v3 1/2] b-tree: return NULL on matras_alloc fail

[Nikita Pettik]

On 31 Jan 11:18, Konstantin Osipov wrote:
> * Nikita Pettik <korablev at tarantool.org> [20/01/21 13:37]:
> > On 20 Jan 21:13, Ilya Kosarev wrote:
> > > In bps_tree_create_leaf we use matras_alloc in case
> > > bps_tree_garbage_pop didn't work out. However it also might not
> > > succeed. Then we need to return NULL instead of dereferencing NULL
> > > pointer.
> 
> I don't understand the attempt to fix it.
> 
> The reason the allocations are not checked - most likely -because
> BPS should refuse to even begin an operation if there is not
> enough memory in matras.

According to the code it doesn't look so. Matras allocation checked
on fails, except two ones in bps_tree_create_inner() and
bps_tree_create_leaf().
 
> Most likely Alexander Lyapunov was relying on that, and this is why you
> don't have these checks all over bps code.> 
> 
> -- 
> Konstantin Osipov, Moscow, Russia