[Tarantool-patches] [PATCH v9 4/7] qsync: direct write of CONFIRM/ROLLBACK into a journal

[Cyrill Gorcunov]

On Thu, Aug 20, 2020 at 12:43:45AM +0200, Vladislav Shpilevoy wrote:
> > +	if (journal_write(entry) != 0 || entry->res < 0) {
> > +		diag_set(ClientError, ER_WAL_IO);
> > +		diag_log();
> > +		/*
> > +		 * XXX: the stub is supposed to be removed once it is defined
> > +		 * what to do when a synchro request WAL write fails. One of
> > +		 * the possible solutions: log the error, keep the limbo
> > +		 * queue as is and probably put in rollback mode. Then
> > +		 * provide a hook to call manually when WAL problems are fixed.
> > +		 * Or retry automatically with some period.
> > +		 */
> > +		panic("Could not write a synchro request to WAL: "
> > +		      "lsn = %lld, type = %s\n", lsn,
> > +		      type == IPROTO_CONFIRM ? "CONFIRM" : "ROLLBACK");
> 
> Why did you inline iproto_type_name(type)?

It happened to sneak in from old commits (I've cherry picked it,
and there were no such code previously). I've fixed it and pushed
into the branch. Thanks for noticing!