[Tarantool-patches] [PATCH v4 10/10] luajit: Fix warnings spotted by luacheck

Sergey Bronnikov sergeyb at tarantool.org
Thu Apr 23 13:30:23 MSK 2020


On 13:03 Thu 23 Apr , Igor Munkin wrote:
> Sergey,
> 
> Thank you for the changes! Sorry for nitpicking, but I still have
> several comments regarding commit message:
> 
> | test: fix warnings spotted by luacheck
> |
> | luacheck is integrated in tarantool CI pipeline and respect .luacheckrc in
> 
> Typo: s/respect/respects/.

Updated in a branch.

> | tarantool repo, so jit global is suppressed there.
> |
> | Reviewed-by: Igor Munkin <imun at tarantool.org>
> | Co-authored-by: Igor Munkin <imun at tarantool.org>
> 
> Minor: I failed to find strict rules about the ordering misc-by tags,
> but here[1] I follows the kernel example[2] where Co-developed-by tag
> (or Co-authored-by alternative) goes prior to Reviewed-by one. I guess
> it would be nice to use a single sort order for the tags. But again, I
> find no rule and tag practice is even optional (it's not mentioned in
> our contributors guide), so feel free to ignore this comment.

Perhaps it make sense. Updated in a branch.

<snipped>


More information about the Tarantool-patches mailing list