[Tarantool-patches] [PATCH v4 10/10] luajit: Fix warnings spotted by luacheck

[Igor Munkin]

Sergey,

Thank you for the changes! Sorry for nitpicking, but I still have
several comments regarding commit message:

| test: fix warnings spotted by luacheck
|
| luacheck is integrated in tarantool CI pipeline and respect .luacheckrc in

Typo: s/respect/respects/.

| tarantool repo, so jit global is suppressed there.
|
| Reviewed-by: Igor Munkin <imun at tarantool.org>
| Co-authored-by: Igor Munkin <imun at tarantool.org>

Minor: I failed to find strict rules about the ordering misc-by tags,
but here[1] I follows the kernel example[2] where Co-developed-by tag
(or Co-authored-by alternative) goes prior to Reviewed-by one. I guess
it would be nice to use a single sort order for the tags. But again, I
find no rule and tag practice is even optional (it's not mentioned in
our contributors guide), so feel free to ignore this comment.

|

Otherwise, LGTM, thanks!

On 23.04.20, Sergey Bronnikov wrote:
> GH branch:
> https://github.com/tarantool/luajit/tree/ligurio/gh-4681-fix-luacheck-warnings
> 
> On 17:00 Tue 21 Apr , sergeyb at tarantool.org wrote:
> > From: Sergey Bronnikov <sergeyb at tarantool.org>

[1]: https://github.com/tarantool/luajit/commit/4f4fd9e
[2]: https://github.com/torvalds/linux/commit/56df70a

-- 
Best regards,
IM