[Tarantool-patches] [PATCH V6 00/10] Extending error functionality

[lvasiliev]

On 20.04.2020 3:26, Vladislav Shpilevoy wrote:
> Hi!
> 
> In short: formally LGTM.
> 
> Long version:
> 
> I don't like doing and reviewing patches in such a hurry.
> This feature clearly lacked planning, design, and discussion
> with community, RFC for the final version before its
> implementation.
> 
> It is still unfinished because of underdesigned traceback
> feature, because of payload absence. IMO, MP_EXT is also an
> overkill. Tuples live fine as MP_ARRAY, and they are the most
> used type. We should have gone for simple MP_MAP, without
> MP_EXT. Just a map.
> 
> It is worth mentioning separately, how hard it is to use the
> error marshaling now, because of this session setting. And
> there still is no way to enable the feature without touching
> the session, even if all my connectors support it. As I
> mentioned, enabling it for every session manually is a
> non-trivial task for a user.
> 
> But we have releases coming, so lets push all in whatever
> state it is, of course.

Hi! Thanks you for the help in implementation.
I tried to write the RFC but my attempt was ignored by everyone.
The first implementation used a map and it was said that MP_EXT
should be used. I will try to take into account the experience
gained and not proceed with the implementation of non-trivial
tasks without LGTM on RFC.
Thanks again for your help.