[Tarantool-patches] [PATCH V6 00/10] Extending error functionality

[Vladislav Shpilevoy]

Hi!

In short: formally LGTM.

Long version:

I don't like doing and reviewing patches in such a hurry.
This feature clearly lacked planning, design, and discussion
with community, RFC for the final version before its
implementation.

It is still unfinished because of underdesigned traceback
feature, because of payload absence. IMO, MP_EXT is also an
overkill. Tuples live fine as MP_ARRAY, and they are the most
used type. We should have gone for simple MP_MAP, without
MP_EXT. Just a map.

It is worth mentioning separately, how hard it is to use the
error marshaling now, because of this session setting. And
there still is no way to enable the feature without touching
the session, even if all my connectors support it. As I
mentioned, enabling it for every session manually is a
non-trivial task for a user.

But we have releases coming, so lets push all in whatever
state it is, of course.