[Tarantool-patches] [PATCH 2/6] Fix luacheck warnings in test/

Sergey Bronnikov sergeyb at tarantool.org
Fri Apr 17 22:51:46 MSK 2020


Igor,

On 15:05 Fri 17 Apr , Igor Munkin wrote:

<snipped>

> > diff --git a/test/app-tap/tarantoolctl.test.lua b/test/app-tap/tarantoolctl.test.lua
> > index 4d7059559..3fda53274 100755
> > --- a/test/app-tap/tarantoolctl.test.lua
> > +++ b/test/app-tap/tarantoolctl.test.lua
> > @@ -97,23 +97,14 @@ local function tctl_wait_start(dir, name)
> >              fiber.sleep(0.01)
> >          end
> >          ::again::
> > -        while true do
> > -            local stat, nb = pcall(require('net.box').new, path, {
> > -                wait_connected = true, console = true
> > -            })
> > -            if stat == false then
> > -                fiber.sleep(0.01)
> > -                goto again
> > -            else
> > -                break
> > -            end
> > -            local stat, msg = pcall(nb.eval, nb, 'require("fiber").time()')
> > -            if stat == false then
> > -                fiber.sleep(0.01)
> > -            else
> > -                break
> > -            end
> > +        local stat, nb = pcall(require('net.box').new, path, {
> 
> I guess you can drop nb here, since it's unused.

'nb' variable has been removed and patch updated, thanks!

<snipped>


More information about the Tarantool-patches mailing list