[Tarantool-patches] [PATCH 2/6] Fix luacheck warnings in test/

Igor Munkin imun at tarantool.org
Fri Apr 17 15:05:31 MSK 2020


Vlad,

Thanks for the fixes!

On 15.04.20, Vladislav Shpilevoy wrote:
> Thanks for the patch!
> 
> Consider more fixes below and on the branch in a separate commit.
> That allowed to remove some warning mutes from the luacheck
> config.
> 
> ====================
> 
>     Review fixes: test/
> 

<snipped>

> diff --git a/test/app-tap/tarantoolctl.test.lua b/test/app-tap/tarantoolctl.test.lua
> index 4d7059559..3fda53274 100755
> --- a/test/app-tap/tarantoolctl.test.lua
> +++ b/test/app-tap/tarantoolctl.test.lua
> @@ -97,23 +97,14 @@ local function tctl_wait_start(dir, name)
>              fiber.sleep(0.01)
>          end
>          ::again::
> -        while true do
> -            local stat, nb = pcall(require('net.box').new, path, {
> -                wait_connected = true, console = true
> -            })
> -            if stat == false then
> -                fiber.sleep(0.01)
> -                goto again
> -            else
> -                break
> -            end
> -            local stat, msg = pcall(nb.eval, nb, 'require("fiber").time()')
> -            if stat == false then
> -                fiber.sleep(0.01)
> -            else
> -                break
> -            end
> +        local stat, nb = pcall(require('net.box').new, path, {

I guess you can drop nb here, since it's unused.

> +            wait_connected = true, console = true
> +        })
> +        if stat == false then
> +            fiber.sleep(0.01)
> +            goto again
>          end
> +        return
>      end
>  end
>  

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list