[Tarantool-patches] [PATCH] Fix luacheck warnings in src/lua/*.lua
Sergey Bronnikov
sergeyb at tarantool.org
Tue Apr 7 18:15:12 MSK 2020
Igor, thanks for your comments. I have updated patch and moved all supressions
from source code to a luacheck config file.
Sergey
On 12:34 Sat 04 Apr , Igor Munkin wrote:
> Sergey,
>
> Thanks for the patch. It's not a review, I just want to add my two cents
> regarding luacheck usage.
>
> 1. Please consider the way style violations are organized in uJIT
> repo[1]. You can also group everything into a single file for better
> further maintenance.
>
> 2. There is also a runner[2] for luacheck, that considers uJIT specifics
> (e.g. ujit table is a global variable similar to Tarantool's box one).
>
> I guess this approach should be considered, even if you decide to make
> the patch your own way.
More information about the Tarantool-patches
mailing list