[Tarantool-patches] [PATCH] Fix luacheck warnings in src/lua/*.lua
Igor Munkin
imun at tarantool.org
Sat Apr 4 12:34:57 MSK 2020
Sergey,
Thanks for the patch. It's not a review, I just want to add my two cents
regarding luacheck usage.
1. Please consider the way style violations are organized in uJIT
repo[1]. You can also group everything into a single file for better
further maintenance.
2. There is also a runner[2] for luacheck, that considers uJIT specifics
(e.g. ujit table is a global variable similar to Tarantool's box one).
I guess this approach should be considered, even if you decide to make
the patch your own way.
On 03.04.20, Sergey Bronnikov wrote:
> GitHub branch: https://github.com/tarantool/tarantool/tree/ligurio/gh-4681-fix-luacheck-warnings
>
> How-to check:
>
> $ tarantoolctl rocks install luacheck
> $ .rocks/bin/luacheck src/lua/*.lua
>
> ---
> src/lua/argparse.lua | 6 ++--
> src/lua/buffer.lua | 4 +--
> src/lua/clock.lua | 2 +-
> src/lua/crypto.lua | 18 +++++-----
> src/lua/csv.lua | 5 ++-
> src/lua/digest.lua | 6 ++--
> src/lua/env.lua | 2 +-
> src/lua/errno.lua | 2 +-
> src/lua/fio.lua | 28 ++++++++--------
> src/lua/help.lua | 24 +++++++-------
> src/lua/httpc.lua | 3 --
> src/lua/init.lua | 17 +++++-----
> src/lua/msgpackffi.lua | 15 ++++-----
> src/lua/socket.lua | 66 ++++++++++++++++++-------------------
> src/lua/string.lua | 1 -
> src/lua/swim.lua | 20 +++++------
> src/lua/tap.lua | 75 ++++++++++++++++++++----------------------
> src/lua/trigger.lua | 3 --
> 18 files changed, 142 insertions(+), 155 deletions(-)
>
<snipped>
>
> --
> sergeyb@
[1]: https://github.com/iponweb/luavela/blob/master/.luacheckrc
[2]: https://github.com/iponweb/luavela/blob/master/scripts/run-luacheck
--
Best regards,
IM
More information about the Tarantool-patches
mailing list