[tarantool-patches] [PATCH 0/2] Fix <CAST> bugs

Roman Khabibov roman.habibov at tarantool.org
Sun Sep 15 22:39:09 MSK 2019


These are two patches that are not particularly related.
* The first fixes the bug with binary garbadge in an error message
which contains non-printable symbols within. I think, this patch
is ugly. It is better to always print value type regardless of its
type in "diag_set(ClientError, ER_SQL_TYPE_MISMATCH, ...)" instead
of value itself.
* The second fixes the bug with wrong <CAST> result type.

Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-4356-cast
Issue: https://github.com/tarantool/tarantool/issues/4356

Roman Khabibov (2):
  sql: do not print binary data in diag_set()
  sql: fix the bug with wrong result type in <CAST>

 src/box/sql/func.c                   |  8 +--
 src/box/sql/sqlInt.h                 | 13 ++++
 src/box/sql/vdbe.c                   | 28 ++++-----
 src/box/sql/vdbeapi.c                |  7 +++
 src/box/sql/vdbemem.c                |  5 +-
 test/sql-tap/cast.test.lua           | 18 ++++--
 test/sql-tap/func.test.lua           | 45 ++++++++++++-
 test/sql-tap/sql-errors.test.lua     | 94 +++++++++++++++++++++++++++-
 test/sql-tap/tkt-80e031a00f.test.lua |  4 +-
 test/sql/types.result                |  8 +--
 10 files changed, 199 insertions(+), 31 deletions(-)

-- 
2.20.1 (Apple Git-117)





More information about the Tarantool-patches mailing list