[tarantool-patches] Re: [PATCH 0/4] JSON update preparation: move code, remove dependencies

Kirill Yukhin kyukhin at tarantool.org
Wed Sep 18 09:14:20 MSK 2019


Hello,

On 15 Sep 19:32, Vladislav Shpilevoy wrote:
> The patchset is a first tiny part of the original patchset:
> https://www.freelists.org/post/tarantool-patches/PATCH-v2-08-JSON-updates
> but split into several small patches.
> 
> Problem of the original patchset is that it is too huge, especially its second
> commit moving `tuple update` code into a separate subfolder with many new files,
> along with minor code changes.
> 
> This patchset gives a chance to review the changes separately from movements:
> refactoring, removal of some unnecessary dependencies, helper functions. All of
> the changes here aimed at making parts of tuple_update.c more relocatable and
> reusable.
> 
> Perhaps this is not the last preparatory patchset. The core commit of the
> original patch contains lots of renames and many new functions about which I am
> not sure whether it is worth sending them separately too. I will try to extract
> something meaningful.
> 
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-1261-update-json-preparation-2
> Issue: https://github.com/tarantool/tarantool/issues/1261

I've checked your patchset into master.

--
Regards, Kirill Yukhin




More information about the Tarantool-patches mailing list