[tarantool-patches] [PATCH 0/4] JSON update preparation: move code, remove dependencies

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sun Sep 15 20:32:13 MSK 2019


The patchset is a first tiny part of the original patchset:
https://www.freelists.org/post/tarantool-patches/PATCH-v2-08-JSON-updates
but split into several small patches.

Problem of the original patchset is that it is too huge, especially its second
commit moving `tuple update` code into a separate subfolder with many new files,
along with minor code changes.

This patchset gives a chance to review the changes separately from movements:
refactoring, removal of some unnecessary dependencies, helper functions. All of
the changes here aimed at making parts of tuple_update.c more relocatable and
reusable.

Perhaps this is not the last preparatory patchset. The core commit of the
original patch contains lots of renames and many new functions about which I am
not sure whether it is worth sending them separately too. I will try to extract
something meaningful.

Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-1261-update-json-preparation-2
Issue: https://github.com/tarantool/tarantool/issues/1261

Vladislav Shpilevoy (4):
  tuple: expose JSON go_to_key and go_to_index functions
  tuple: rework update error reporting
  tuple: update splice should not use index_base after reading args
  tuple: remove some dependencies on struct tuple_update and rope

 src/box/errcode.h      |  10 +-
 src/box/tuple.c        |  21 +--
 src/box/tuple.h        |  23 +++
 src/box/tuple_update.c | 353 +++++++++++++++++++++--------------------
 test/box/misc.result   |   2 +-
 test/box/update.result |   4 +-
 6 files changed, 214 insertions(+), 199 deletions(-)

-- 
2.20.1 (Apple Git-117)





More information about the Tarantool-patches mailing list