[tarantool-patches] Re: [PATCH v2 0/4] Serializer bugs

[Vladislav Shpilevoy]

Hi!

Thanks for the review!

On 13/09/2019 01:44, Alexander Turenko wrote:
> On Mon, Sep 09, 2019 at 09:00:06PM +0200, Vladislav Shpilevoy wrote:
>> The patchset fixes several problems about JSON and msgpack serializers.
>>
>> 1) msgpackffi didn't use msgpack serializer options;
>> 2) tuple serializer either;
>> 3) update of a serializer option was not reflected in its Lua representation;
>> 4) during serialization too nested tables are silently cropped and there was no
>>   way to prevent it.
>>
>> Also it was discovered, that msgpackffi does not care *all* options. Not only
>> about max_depth. I am not sure if it is worth fixing here (or at all) though.
> 
> I would not do it here. However it worth to file a follow up issue: we
> should either fix or document this behaviour. It seems that it may be
> very unexpected that space:update / upsert does not follow, say,
> encode_invalid_numbers (if a user use this option and see that it works
> for other box functions).

https://github.com/tarantool/tarantool/issues/4499