[tarantool-patches] [PATCH 0/4] Serializer bugs

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Sep 5 00:44:43 MSK 2019


The patchset fixes several problems about JSON and msgpack serializers.

1) msgpackffi didn't use msgpack serializer options;
2) tuple serializer either;
3) update of a serializer option was not reflected in its Lua representation;
4) during serialization too nested tables are silently cropped and there was no
  way to prevent it.

The patchset depends on fix of #4366 provided by Kirill.

Also it was discovered, that msgpackffi does not care *all* options. Not only
about max_depth. I am not sure if it is worth fixing here (or at all) though.

Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4434-box-lua-msgpack-cfg
Issue: https://github.com/tarantool/tarantool/issues/4434

Vladislav Shpilevoy (4):
  app: serializers update now is reflected in Lua
  msgpack: make msgpackffi use encode_max_depth option
  tuple: use global msgpack serializer in Lua tuple
  app: allow to raise an error on too nested tables

 src/box/lua/tuple.c                  | 32 +++++++++++++------
 src/lua/msgpack.c                    |  4 +++
 src/lua/msgpackffi.lua               |  6 ++--
 src/lua/utils.c                      | 37 ++++++++++++----------
 src/lua/utils.h                      | 15 +++++++++
 test/app-tap/json.test.lua           |  3 +-
 test/app-tap/lua/serializer_test.lua | 31 +++++++++++++++++++
 test/app-tap/msgpack.test.lua        |  3 +-
 test/app-tap/msgpackffi.test.lua     | 30 +++++++++++++++++-
 test/box/tuple.result                | 46 ++++++++++++++++++++++++++++
 test/box/tuple.test.lua              | 21 +++++++++++++
 test/unit/luaT_tuple_new.c           |  2 +-
 third_party/lua-cjson/lua_cjson.c    | 10 ++++--
 13 files changed, 207 insertions(+), 33 deletions(-)

-- 
2.20.1 (Apple Git-117)





More information about the Tarantool-patches mailing list