[tarantool-patches] Re: [PATCH v3 5/6] iproto: refactor error encoding with mpstream

Konstantin Osipov kostja at tarantool.org
Wed Sep 4 13:53:11 MSK 2019


* Kirill Shcherbatov <kshcherbatov at tarantool.org> [19/09/02 17:55]:
> +static void
> +mpstream_error_handler(void *error_ctx)
> +{
> +	*(bool *)error_ctx = true;
> +}
> +
> +static void
> +mpstream_iproto_encode_error(struct mpstream *stream, const struct error *error)

I think the name should be encode_error_in_mpstream().

Basically, the convention is:
- if it is an mpstream method, its name is mpstream_verb_subject
- if it is error method, the name is error_verb_subject
- if it is a standalone function, the name is
  verb_subject_.._subject.

-- 
Konstantin Osipov, Moscow, Russia




More information about the Tarantool-patches mailing list