[tarantool-patches] Re[2]: [tarantool-patches] [PATCH 1/6] box/console: Add mapping for direct symbols

[Sergey Ostanevich]

Sure, separate patch is OK if you do not envision any other problem with such a move.


Sent from Mail.ru app for iOS


Monday, 9 September 2019, 18:54 +0300 from gorcunov at gmail.com  <gorcunov at gmail.com>:
>On Mon, Sep 09, 2019 at 06:11:44PM +0300, Sergey Ostanevich wrote:
>>    Cyrill,
>> 
>>    Why not to move the map_direct_symbols to the module level, so that
>>    creation and
>>    fill of the table will happens only once and not at every call to the
>>    output handler?
>
>Well, initially I thought to keep such things inside serializer helper
>so that if we need we will easily extend this table and the change
>will be inside function context. I must admit I think all this comes
>from a strong habbit of working with compilers where such thing would
>be simply optimized. That said I agree we should do so.
>
>I think this issue could be addressed on top as a separate patch?
>Just to not resend the whole series.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20190910/9db23957/attachment.html>