<HTML><BODY><div id="composeWebView_editable_content" data-mailruapp-compose-id="composeWebView_editable_content" style="text-align: left;"><div><br></div><div>Sure, separate patch is OK if you do not envision any other problem with such a move.</div><div id="mail-app-auto-default-signature"><br><br>Sent from Mail.ru app for iOS<br></div><br><br>Monday, 9 September 2019, 18:54 +0300 from gorcunov@gmail.com <gorcunov@gmail.com>:<br> <div id="composeWebView_previouse_content" data-mailruapp-compose-id="composeWebView_previouse_content"><blockquote id="mail-app-auto-quote" style="border-left-width: 1px; border-left-style: solid; border-left-color: rgb(0, 95, 249); margin: 10px 0px 10px 5px; padding: 0px 0px 0px 10px; display: inherit;"><div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<base target="_self" href="https://e.mail.ru/">
<div id="style_15680444700842545957_BODY">On Mon, Sep 09, 2019 at 06:11:44PM +0300, Sergey Ostanevich wrote:<br>
> Cyrill,<br>
> <br>
> Why not to move the map_direct_symbols to the module level, so that<br>
> creation and<br>
> fill of the table will happens only once and not at every call to the<br>
> output handler?<br>
<br>
Well, initially I thought to keep such things inside serializer helper<br>
so that if we need we will easily extend this table and the change<br>
will be inside function context. I must admit I think all this comes<br>
from a strong habbit of working with compilers where such thing would<br>
be simply optimized. That said I agree we should do so.<br>
<br>
I think this issue could be addressed on top as a separate patch?<br>
Just to not resend the whole series.<br>
</div>
<base target="_self" href="https://e.mail.ru/">
</div>
</div></blockquote></div></div></BODY></HTML>