[tarantool-patches] Re: [PATCH v1 1/1] http: fix httpc auto-managed headers

[Vladimir Davydov]

On Thu, Mar 07, 2019 at 05:48:20PM +0300, Kirill Shcherbatov wrote:
> > I don't like how httpc internal API now looks like: one should set
> > headers before the method/url and keepalive options, otherwise he/she
> > risks loosing them. And there isn't a word about this idiosyncrasy
> > anywhere in the comments.
> > 
> > Also, splitting request construction into allocation (_new) and
> > method/url initialization (_set_url) looks ugly to me, because no
> > request makes sense without them.
> > 
> > May be, we could set default headers in httpc_execute instead?
> No, when those headers are set, they use specific context: like size, idle etx.

You can store them in httpc_request, can't you?