[tarantool-patches] Re: [PATCH 0/2] Add collation to built-in funcs and fix HAVING clause with aggregate

[Vladislav Shpilevoy]

LGTM.

On 21/02/2019 21:01, Nikita Pettik wrote:
> Issue #3932 consists of two independent bugs. Current patch-set
> provides fixes for both of them.
> 
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3932-function-collation
> Issue: https://github.com/tarantool/tarantool/issues/3932
> 
> Nikita Pettik (2):
>    sql: derive collation for built-in functions
>    sql: fix code generation for aggregate in HAVING clause
> 
>   src/box/sql/analyze.c         |  6 +++---
>   src/box/sql/expr.c            | 23 +++++++++++++++++++++++
>   src/box/sql/func.c            | 22 +++++++++++-----------
>   src/box/sql/resolve.c         | 10 +++++++---
>   src/box/sql/sqlInt.h          | 31 +++++++++++++++++++++++--------
>   test/sql-tap/select5.test.lua | 25 ++++++++++++++++++++++++-
>   test/sql/collation.result     | 28 ++++++++++++++++++++++++++++
>   test/sql/collation.test.lua   | 11 +++++++++++
>   8 files changed, 130 insertions(+), 26 deletions(-)
> 
> -- 
> 2.15.1
>