[tarantool-patches] Re: [PATCH v3 8/9] sql: rework three errors of "unsupported" type

[Konstantin Osipov]

* n.pettik <korablev at tarantool.org> [19/03/05 12:37]:

> > +	/*194 */_(ER_SQL_ANALYZE_ARGUMENT,	"ANALYZE statement argument %s is not a base table") \
> 
> Why does this error deserve to be so special?

I don't know. Should analyze work for a sysview?

> To be honest, I would remove it at all and simply
> do nothing in case of view is analysed.

This would seep DBA mistakes under the carpet.

> Or make it
> raise not only for views, but in several other cases.
> For instance, what if we analyse space without
> format or indexes? Spoiler: it leads to assertion fault
> 
> Assertion failed: (space->index_count != 0), function vdbe_emit_analyze_space, file /Users/n.pettik/tarantool/src/box/sql/analyze.c, line 799.
> Abort trap: 6

This should work.

Generally, I think it's bikeshed and not worth arguing about. Do
you see any practical consequence from following my preference?
> 

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov