[tarantool-patches] Re: [PATCH v3 8/9] sql: rework three errors of "unsupported" type

[n.pettik]

> diff --git a/src/box/errcode.h b/src/box/errcode.h
> index 06f7a63..f2ea27a 100644
> --- a/src/box/errcode.h
> +++ b/src/box/errcode.h
> @@ -246,6 +246,7 @@ struct errcode_record {
> 	/*191 */_(ER_HEX_LITERAL_MAX,		"Hex literal %s%s length %d exceeds the supported limit (%d)") \
> 	/*192 */_(ER_INT_LITERAL_MAX,		"Integer literal %s%s exceeds the supported range %lld - %lld") \
> 	/*193 */_(ER_SQL_PARSER_LIMIT,		"%s%.*s %d exceeds the limit (%d)") \
> +	/*194 */_(ER_SQL_ANALYZE_ARGUMENT,	"ANALYZE statement argument %s is not a base table") \

Why does this error deserve to be so special?
To be honest, I would remove it at all and simply
do nothing in case of view is analysed. Or make it
raise not only for views, but in several other cases.
For instance, what if we analyse space without
format or indexes? Spoiler: it leads to assertion fault

Assertion failed: (space->index_count != 0), function vdbe_emit_analyze_space, file /Users/n.pettik/tarantool/src/box/sql/analyze.c, line 799.
Abort trap: 6