[PATCH 1/2] lib/core/fiber: Rename stack_direction to stack_growsdown

Cyrill Gorcunov gorcunov at gmail.com
Wed Mar 27 13:30:23 MSK 2019


On Wed, Mar 27, 2019 at 01:20:37PM +0300, Vladimir Davydov wrote:
> > 
> > Symmetrical with what? :)
> 
> +1 / -1 you now :)
> 
>   direction < 0
>   direction > 0
> 
> instead of
> 
>   growsdown
>   !growsdown

OK (jfyi: growsup/down is not only mman specifics but intel sdm as well)

> > > I'd refrain from changing this if there's no other reason rather than
> > > personal taste.
> > 
> > It is not personal taste but rather a common naming (mman syscall).
> > Though I don't insist.
> 
> I wouldn't mind if it was committed. Just that I don't really like
> committing minor changes like this so as not to pollute the git history
> without a strong reason. Up to Kirill or Kostja.

OK, lets drop it. This is nop from functionl pov anyway.



More information about the Tarantool-patches mailing list