[tarantool-patches] Re: [PATCH v1] test: use unix sockets iproto

[Alexander Turenko]

I'm ok with the change itself, so formally LGTM. Please, proceed further
with Kirill.

WBR, Alexander Turenko.

> test: use unix sockets iproto

Typo: iproto -> for iproto. Maybe better 'test: use unix sockets for
iproto connections'.

First of all I would state explicitly 'why': "eliminated most of
'address already in use' errors seen from time to time in our testing".
Then you can describe the reason of those fails, provide information
about previous tries to solve it, give needed background and so on.

> Enabled use_unix_sockets and use_unix_sockets_iproto options

use_unix_sockets is already enabled, the phrase is misleading.

> to use unix sockets iproto instead of TcpPortDispatcher which
> was previously introduced to eliminate the race condition when
> two workers trying to use the same port: the idea was that each
> worker used its own ports range. Really these ports could race
> with client ports (from, say, net.box or replication), which
> typically didn't use bind() and so bound to a random available
> port (despite any dispatched ranges) and could produce
> 'Address already in use' error.

I would separate a description of the new way to handle the problem
('Enabled use_unix_sockets_iproto option to let test-run appoint unix
sockets for LISTEN environment variable values') and a description of
previous approaches ('TCP port ranges and so on') if you really want to
give enough context and describe the latter one entirely. It is not
obligatory I think.

I mean, now it is not easy to understand that you describe disadvantages
on a *previous* approach and almost all this paragraph is not about a
code that is enabled in this commit.

I think it can mislead someone if (s)he has less knowledge around
test-run then you. You are formally right however, so ignore my wording
nitpicking if you don't agree and just proceed with Kirill.

> 
> Closes: #4008
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4008-test-in-parallel-iproto
> Issue: https://github.com/tarantool/tarantool/issues/4008