[tarantool-patches] Re: [PATCH v1 1/2] Enable http_client test

Alexander Turenko alexander.turenko at tarantool.org
Fri Jun 7 05:40:59 MSK 2019


I'm okay with the code, but see minor comments below. LGTM formally,
please fix the comments and proceed with Kirill directly.

I would not split the patchset into two commits, just mention that
you're reverts changes made by the certain commit.

BTW, don't forget to write a cover letter when sending a patchset of
more then one patch (it is not applicable here however if you'll squash
this patchset, just reminder).

Please, use prefix 'test: ' for commits that changes only tests.

WBR, Alexander Turenko.

On Thu, Jun 06, 2019 at 03:24:54PM +0300, Alexander V. Tikhonov wrote:
> Removed skip flag file to switch on the testing of the
> http_client test. Enabled http_client test on OSX,
> fixed missing of the python2 link. Removed the subtest

I would be more specific: link -> symlink.

> on '595 error return' from 'error' suite, due to it may
> hang forever.
> 
> Closes #4254
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4254-try-on-travis
> Issue: https://github.com/tarantool/tarantool/issues/4254




More information about the Tarantool-patches mailing list