[tarantool-patches] [PATCH v3 10/14] core: latch_unlock_external routine

Vladimir Davydov vdavydov.dev at gmail.com
Fri Jun 14 12:18:14 MSK 2019


On Fri, Jun 14, 2019 at 11:10:08AM +0300, Vladimir Davydov wrote:
> On Thu, Jun 13, 2019 at 10:38:12PM +0300, Георгий Кириченко wrote:
> > On Thursday, June 13, 2019 5:27:35 PM MSK Vladimir Davydov wrote:
> > > On Sun, Jun 09, 2019 at 11:44:39PM +0300, Georgy Kirichenko wrote:
> > > 
> > > Again, looks like a temporary hack to me. I would rather not commit it.
> > > The right way would be getting rid of the schema_lock. I know that you
> > > have tried, but failed because of vylog. I'll look what we can do about
> > > it.
> > I failed to remove the latch from checkpoint not from ddl. Removing the latch 
> > from alter.cc doesn't look possible in the next 2-3 month.
> 
> I'll look what we can do about this - AFAICS there are no problems with
> memtx. We just need to tweak vinyl somehow.

Discussed f2f. Looks like we can't easily remove the latch, because we
do need it for synching DDL-vs-DDL (we can remove it from checkpointing,
but that's not enough).

Still, latch_unlock_external looks so ugly :(

May be, we could move it to be called before submitting a record to WAL
rather than after? Something like, before_commit trigger, may be?



More information about the Tarantool-patches mailing list