[tarantool-patches] Re: [PATCH v1 25/28] sql: remove sql_log()

[Vladislav Shpilevoy]

Thanks for the patch!

Consider my review fixes below and on the branch
in a separate commit.

======================================================

diff --git a/src/box/sql/global.c b/src/box/sql/global.c
index 0bbd8c2fd..c3c7e945c 100644
--- a/src/box/sql/global.c
+++ b/src/box/sql/global.c
@@ -196,8 +196,6 @@ SQL_WSD struct sqlConfig sqlConfig = {
 	0,			/* isInit */
 	0,			/* inProgress */
 	0,			/* isMallocInit */
-	0,			/* xLog */
-	0,			/* pLogArg */
 #ifdef SQL_VDBE_COVERAGE
 	0,			/* xVdbeBranch */
 	0,			/* pVbeBranchArg */
diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h
index 097f9730a..9b0928d0a 100644
--- a/src/box/sql/sqlInt.h
+++ b/src/box/sql/sqlInt.h
@@ -2752,8 +2752,6 @@ struct sqlConfig {
 	int isInit;		/* True after initialization has finished */
 	int inProgress;		/* True while initialization in progress */
 	int isMallocInit;	/* True after malloc is initialized */
-	void (*xLog) (void *, int, const char *);	/* Function for logging */
-	void *pLogArg;		/* First argument to xLog() */
 #ifdef SQL_VDBE_COVERAGE
 	/* The following callback (if not NULL) is invoked on every VDBE branch
 	 * operation.  Set the callback using sql_TESTCTRL_VDBE_COVERAGE.