[tarantool-patches] Re: [RFC 2/2] box/lua/console: Add support for lua output format

Cyrill Gorcunov gorcunov at gmail.com
Sat Jul 6 23:35:37 MSK 2019


On Sat, Jul 06, 2019 at 07:02:39PM +0300, Konstantin Osipov wrote:
> > 
> > Since it gonna be new session the settings will be reset. I thought
> > also that we might need to provide some box.cgf option for default
> > output mode?
> 
> Yes, but it could be box.session setting, not box.cfg.

OK, will take a look, thanks!

> > > Perhaps we should cache it on the client as well (this is the same
> > > issue with console language).
> > 
> > Well, seems so, still it is a bit unclear for me where to keep this
> > cached value.
> 
> I think having a default is good enough.

ok

> > As to "default lua" for 2.x series we need to think how to tune
> > up our test engine to setup yaml mode for all tests, since currently
> > test results are in yaml and we definitely don't wanna update every
> > test exsiting.
> 
> Well, at least every new test should use the new output. There
> aren't that many results, and it's just results - not tests - so
> they won't be hard to merge (re-run the test  and compare the
> diff). Besides, 1.10 is more or less frozen, it accepts only minor
> bugfixes. Now it's a perfect time.

got it, thanks!




More information about the Tarantool-patches mailing list