[tarantool-patches] Re: [RFC 2/2] box/lua/console: Add support for lua output format

[Alexander Turenko]

On Sat, Jul 06, 2019 at 07:02:39PM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov at gmail.com> [19/07/06 17:40]:
> > On Sat, Jul 06, 2019 at 01:59:08AM +0300, Konstantin Osipov wrote:
> > > * Cyrill Gorcunov <gorcunov at gmail.com> [19/07/06 00:13]:
> > > 
> > > LGTM. @totktonada, please provide a more thorough review.

Okay.

> > > 
> > > One question is what happens to the output on client reconnect.
> > 
> > Since it gonna be new session the settings will be reset. I thought
> > also that we might need to provide some box.cgf option for default
> > output mode?
> 
> Yes, but it could be box.session setting, not box.cfg.

Related questions I'm tentative about:

* Is there a way to keep an old session after reconnection?
* Is there way to share a session for a connection pool?

> 
> 
> > > Perhaps we should cache it on the client as well (this is the same
> > > issue with console language).
> > 
> > Well, seems so, still it is a bit unclear for me where to keep this
> > cached value.
> 
> I think having a default is good enough.
> 
> > As to "default lua" for 2.x series we need to think how to tune
> > up our test engine to setup yaml mode for all tests, since currently
> > test results are in yaml and we definitely don't wanna update every
> > test exsiting.
> 
> Well, at least every new test should use the new output. There
> aren't that many results, and it's just results - not tests - so
> they won't be hard to merge (re-run the test  and compare the
> diff). Besides, 1.10 is more or less frozen, it accepts only minor
> bugfixes. Now it's a perfect time.

I guess the lua output format support will not be part of 1.10 branch?
If we'll change all test result files, then cherry-picking anything
backward to 1.10 will require extra work. So I don't think we should
convert old result files. 1.10 is alive, so I doubt it actually can be
frozen.

Re using lua output for new test result files. We'll need to write an
output format into a result file header. This requires to bump a result
file format version and implement the new logic in test-run only for
them (I don't see other backward compatible ways for now).

I'm also afraid that the inconsistency in result file formats (one of
which is not supported by 1.10) can give us problems if we'll decide to
backport something to 1.10 after it will land to master with a test in
the new format.

So lua output by default for new tests seems to be doable feature, but
will increase complexity of our test harness and will possibly
problematic in some (rare?) cases.

Are there any real problems with yaml result files?