[tarantool-patches] Re: [PATCH v2 1/5] sql: introduce structs assembling DDL arguments during parsing

[n.pettik]

> On 24 Jan 2019, at 11:36, Konstantin Osipov <kostja at tarantool.org> wrote:
> 
> * Nikita Pettik <korablev at tarantool.org> [19/01/23 23:01]:
>> +	/**
>> +	 * One of parse_def structures which are used to
>> +	 * assemble and carry arguments of DDL routines
>> +	 * from parse.y
>> +	 */
>> +	void *alter_entity_def;
> 
> Please consider adding a type code to the base entity def, so that
> you can use a base struct reference rather than void *. 

Please, look at code and explain why do we need type
code? At first I added it, but it turned out that such code
was completely useless. The only real usage was to
assert that type of structure matches with its code.