[tarantool-patches] Re: [PATCH v2 1/5] sql: introduce structs assembling DDL arguments during parsing
kostja at tarantool.org
Thu Jan 24 15:30:59 MSK 2019
* n.pettik <korablev at tarantool.org> [19/01/24 13:51]:
> >> + * One of parse_def structures which are used to
> >> + * assemble and carry arguments of DDL routines
> >> + * from parse.y
> >> + */
> >> + void *alter_entity_def;
> > Please consider adding a type code to the base entity def, so that
> > you can use a base struct reference rather than void *.
> Please, look at code and explain why do we need type
> code? At first I added it, but it turned out that such code
> was completely useless. The only real usage was to
> assert that type of structure matches with its code.
To assert the structure matches with its code.
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
More information about the Tarantool-patches