[tarantool-patches] Re: [PATCH v2 2/5] sql: rework syntax errors

[Konstantin Osipov]

* n.pettik <korablev at tarantool.org> [19/02/25 23:05]:
> Quite strange name for err code.
> I’d rather say ER_SQL_UNRECOGNIZED_SYMBOL/SYNTAX.
> Is this message suggested by Konstantin? To be honest, I would
> prefer old one. “Unrecognized syntax” doesn’t sound good and clear enough,
> at least for me. Personally I would say “Syntax error near %s”.
> The last one is used in several DBs, so I suppose it is common way to raise
> errors like that.

Yes, the name is suggested by me. There is a name clash with a
generic ER_SYNTAX_ERROR. I also requested to add line/character
numbers to the error message, which I don't see in the patch. 

Mergen, did you find that this is not possible to do?


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov