[tarantool-patches] Re: [PATCH v2 2/5] sql: rework syntax errors

[Imeev Mergen]

Hi! Thank you for review. My answer below

On 2/26/19 11:24 AM, Konstantin Osipov wrote:
> * n.pettik <korablev at tarantool.org> [19/02/25 23:05]:
>> Quite strange name for err code.
>> I’d rather say ER_SQL_UNRECOGNIZED_SYMBOL/SYNTAX.
>> Is this message suggested by Konstantin? To be honest, I would
>> prefer old one. “Unrecognized syntax” doesn’t sound good and clear enough,
>> at least for me. Personally I would say “Syntax error near %s”.
>> The last one is used in several DBs, so I suppose it is common way to raise
>> errors like that.
> Yes, the name is suggested by me. There is a name clash with a
> generic ER_SYNTAX_ERROR. I also requested to add line/character
> numbers to the error message, which I don't see in the patch.
>
> Mergen, did you find that this is not possible to do?
As far as I understand, this is not yet possible. All '\ n' are
currently treated as spaces. To change this, we need to define a
new character class in tokenize.c and make all related changes to
the parser. I do not think that this should be done in issue 3965.
May I mention this later as a follow-up of the issue?
>
>