[tarantool-patches] Re: [PATCH v2 5/5] sql: introduce ALTER TABLE ADD CONSTRAINT UNIQUE/PRIMARY KEY

n.pettik korablev at tarantool.org
Fri Feb 8 20:36:17 MSK 2019



> On 8 Feb 2019, at 20:16, Konstantin Osipov <kostja at tarantool.org> wrote:
> 
> * Nikita Pettik <korablev at tarantool.org> [19/01/23 21:03]:
>> +static void
>> +pk_check_existence(struct Parse *parse, uint32_t space_id, int _index_cursor)
> 
> Tarantool function naming scheme is
> modulename-subject-verb-object.
> 
> I applaud to an attempt to make the code follow Tarantool coding
> style, but please do follow it then.

I remember that I should fix this naming.
But firstly, I must deal with the first part of current patch-set.
When I get to the last commit, I will rename function to
“vdbe_emit_pk_existence_check” or sort of
(hope module name is redundant since it is a static function).

> 
> -- 
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
> 





More information about the Tarantool-patches mailing list