[tarantool-patches] Re: [PATCH v10 3/4] sql: create box.execute()

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Apr 2 12:33:43 MSK 2019



On 02/04/2019 12:22, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/04/02 11:29]:
>> On 02/04/2019 11:13, Konstantin Osipov wrote:
>>> * Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/04/01 23:03]:
>>>> +	if (column_count > 0) {
>>>> +		lua_createtable(L, 0, 2);
>>>> +		lua_sql_get_description(stmt, L, column_count);
>>>> +		lua_setfield(L, -2, "metadata");
>>>
>>> Could we rename lua_qsl_get_description() to
>>> lua_sql_get_metadata() to be consistent in naming?
>>
>> No, we couldn't. Consistent naming is name the methods
>> the same way, and box/execute.c uses term 'description',
>> not 'metadata'.
> 
> Why not rename all the way through, including box/execute.c?

Because I am trying to keep the git history as clean as possible.
But as you wish, as usual. Merge, please, do it.

> 
> -- 
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
> 




More information about the Tarantool-patches mailing list