[tarantool-patches] Re: [PATCH v10 3/4] sql: create box.execute()

Konstantin Osipov kostja at tarantool.org
Tue Apr 2 11:55:02 MSK 2019


* Imeev Mergen <imeevma at tarantool.org> [19/04/02 11:34]:

Sure.

> On 4/2/19 11:21 AM, Konstantin Osipov wrote:
> > * Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/04/01 23:03]:
> > > +		luaL_pushuint64(L, db->nChange);
> > > +		lua_setfield(L, -2, "rowcount");
> > Another small nit is about this name. We write
> > IPROTO_SQL_ROW_COUNT as a key name, but rowcount (note no
> > underscore) in Lua. I would either use a consistent naming (either
> > with or without underscore), or, better yet, find a name which
> > doesn't provoke confusion.
> > Considering we use autoincrement_ids (notice absence of space
> > after auto), I'd call the member row_count.
> > 
> > 
> Do you mind if I do this as follow up separate patch? Also I plan
> to use sql_info_key_strs in netbox_decode_sql_info() and
> port_sql_dump_lua() for this.
> 

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov




More information about the Tarantool-patches mailing list