[tarantool-patches] Re: [PATCH v3 3/7] box: move offset_slot init to tuple_format_add_field
Kirill Shcherbatov
kshcherbatov at tarantool.org
Fri Apr 5 20:17:29 MSK 2019
> I actually had a nit about this patch, I think 3 goto labels in
> such a simple function is a bit of an overkill - the code is
> harder to follow than necessary. I would ditch the 'cleanup'
> label, this would make the code simpler
Hi! Ok! I'll try to fix it with central patch that would touch this code region.
I will deal with the last patch fixes one week later, after vacation.
After investigation the causes of degradation on SQL tests conducted by Alexander,
I think we can not worry about initializing the field map and concentrate on featured
tuple_format_iterator.
More information about the Tarantool-patches
mailing list