[tarantool-patches] [PATCH v3 3/7] box: move offset_slot init to tuple_format_add_field

Konstantin Osipov kostja at tarantool.org
Thu Apr 4 09:19:44 MSK 2019


* Kirill Shcherbatov <kshcherbatov at tarantool.org> [19/04/02 19:27]:
> Due to the fact that the allocation of offset_slot in the case of
> multikey indexes will become more complicated and will be
> necessary for intermediate nodes of the tuple_field tree, we must
> move this logic to the tuple_format_add_field that performs
> an intermediate nodes allocation for a JSON path.

I actually had a nit about this patch, I think 3 goto labels in
such a simple function is a bit of an overkill - the code is
harder to follow than necessary. I would ditch the 'cleanup'
label, this would make the code simpler.




More information about the Tarantool-patches mailing list