[tarantool-patches] Re: [PATCH v1 1/1] sql: invalid integer type in arithmetic operations

Kirill Shcherbatov kshcherbatov at tarantool.org
Thu Apr 25 14:07:56 MSK 2019


>> SQL *is* server. Please begin by having a comment containing a
>> table for integer type arithmetics, something like this:
>>
>>   Plus operation:
>>   --------------
>>   
>>                integer   float
>>
>>   integer      integer   float
>>   float        float     float
>>
>> It's best to implement such table in the source code too, and not
>> have complicated branching.
> 
> Re UNSIGNED type itself:
> 
> once you have a proper table for type arithmetics, it will be easy
> to understand what the result of unsigned + unsigned should be.
> Most likely it should be unsigned, not a number.

Exactly this logic is already on master branch (but only with few sequential ifs, not a table).




More information about the Tarantool-patches mailing list